handle storage not available when expiring versions #43078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
requested review from
a team,
Altahrim,
ArtificialOwl and
artonge
and removed request for
a team
artonge
approved these changes
Jan 24, 2024
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
sorbaugh
approved these changes
Jan 25, 2024
This was referenced Jan 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the expire from crashing when, for example, a remote share isn't available.
Since any version from a non-available storage might be named, it doesn't expire them. This might lead to some extra versions being kept around longer than needed but seems preferable over accidentally deleting a named version.