disable the internal s3sdk multi part copy logic #43086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
Altahrim,
ArtificialOwl and
nfebe
and removed request for
a team
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
nfebe
approved these changes
Jan 25, 2024
Contributor
nfebe
left a comment
nfebe
left a comment
There was a problem hiding this comment.
Looks okay.
However, if default is max, then it might be unnecessary?
icewind1991
force-pushed
the
s3-internal-multipart-copy-disable
branch
2 times, most recently
from
518e8fe to
8cbfecf
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
s3-internal-multipart-copy-disable
branch
from
8cbfecf to
c54f7bd
Compare
Altahrim
approved these changes
Mar 6, 2024
This was referenced Mar 7, 2024
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have our own logic so just set the threshold in the library to 2^64-1