Skip to content

fix(settings): federation scope menu a11y #43098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 3 commits into from
Jan 25, 2024
Merged

fix(settings): federation scope menu a11y #43098

susnux merged 3 commits into from
Jan 25, 2024

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 24, 2024 •
edited
Loading

Summary

Use new radio behavior feature from NcActionButton.

  • Remove intermediate FederationControlAction
    • NcActions doesn't fully support intermediate components
    • Fixes the menu role
    • Fixes keyboard navigation - Tab switches to the next UI element
  • Use new type="radio"
    • Adjusts to menuitemradio role
  • Remove custom styles to use new defaults
  • Slightly fix padding on a small additional button
    Before After
    image image

Screenshots

Before After
image image

We also have now the default design for radio menus. See discussion in nextcloud-libraries/nextcloud-vue#4744 (comment)

So I also removed the custom design. cc @nextcloud/designers

Old custom design New default design
image image

Checklist

@ShGKme ShGKme added this to the Nextcloud 29 milestone Jan 24, 2024
@ShGKme ShGKme self-assigned this Jan 24, 2024
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

jancborchardt
jancborchardt approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, looks great to me design-wise. :)

@susnux susnux merged commit 8e9d89a into master Jan 25, 2024
@susnux susnux deleted the fix/41903/settings--change-scope-a11y branch January 25, 2024 10:41
@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Jan 25, 2024

/backport to stable28

@backportbot backportbot bot mentioned this pull request Jan 25, 2024
Merged
2 tasks
@ShGKme ShGKme mentioned this pull request Feb 28, 2024
Merged
4 tasks
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@ShGKme ShGKme

Labels

3. to review Waiting for reviews accessibility bug feature: settings

Projects

None yet

Milestone

Nextcloud 29

6 participants

@ShGKme @JuliaKirschenheuter @jancborchardt @susnux @Pytal