Skip to content

[stable27 ONLY] fix(trashbin) Switch parseWebdavPermissions->davParsePermissions #43136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 1 commit into from
Jan 26, 2024
Merged

[stable27 ONLY] fix(trashbin) Switch parseWebdavPermissions->davParsePermissions #43136

susnux merged 1 commit into from
Jan 26, 2024

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jan 25, 2024 •
edited by susnux
Loading

Summary

parseWebdavPermissions was renamed to davParsePermissions in nextcloud-libraries/nextcloud-files#706 but the v27 trashbin was not adapted to it.

TODO

  • ...

Checklist

@joshtrichards
Copy link
Member Author

joshtrichards commented Jan 25, 2024

/compile amend

@joshtrichards joshtrichards changed the title fix(trashbin) Switch parseWebdavPermissions->davParsePermissions [stable27 ONLY] fix(trashbin) Switch parseWebdavPermissions->davParsePermissions Jan 25, 2024
@joshtrichards joshtrichards mentioned this pull request Jan 25, 2024
Closed
8 tasks
@nextcloud-command nextcloud-command force-pushed the jr/fix/trashbin-parse-files-api branch from ab1cde0 to b76f446 Compare January 25, 2024 22:41
@joshtrichards joshtrichards linked an issue Jan 25, 2024 that may be closed by this pull request
[Bug]: v27.1.6 - Deleted files view (files_trashbin) does not show deleted files #43134
Closed
8 tasks
@susnux susnux requested review from a team, nfebe, skjnldsv and sorbaugh and removed request for a team January 25, 2024 23:20
@susnux susnux added this to the Nextcloud 27.1.7 milestone Jan 25, 2024
solracsf
solracsf approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@solracsf solracsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works ✅

@susnux susnux merged commit c7cf447 into stable27 Jan 26, 2024
@susnux susnux deleted the jr/fix/trashbin-parse-files-api branch January 26, 2024 13:36
This was referenced Jan 30, 2024
Closed
Closed
@marcelklehr marcelklehr mentioned this pull request Feb 1, 2024
Merged
4 tasks
@sistemi-nv
Copy link

sistemi-nv commented Feb 7, 2024

I'm a newbie with versioning and GIT, but from what I can understand this fix is still not merged to the Stable27 release.
Because this feature is fundamental for the NC platform, can I ask if it it is planned or possible to make a new 27 release with the fix?
Unluckily the 28 Release has still many bugs and regressions (i.e. Drag'n Drop still broken for Safari, #42366) and, in my experience, is still not usable ...
So I hope for a better 27 :)
Many thanks

@joshtrichards
Copy link
Member Author

joshtrichards commented Feb 7, 2024

@sistemi-nv Upcoming v27.1.7 along with the root cause fix via #43259

This was referenced Feb 9, 2024
Closed
Merged
@niende niende mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solracsf solracsf solracsf approved these changes

@nfebe nfebe nfebe approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: files regression

Projects

None yet

Milestone

Nextcloud 27.1.7

Development

Successfully merging this pull request may close these issues.

[Bug]: v27.1.6 - Deleted files view (files_trashbin) does not show deleted files

6 participants

@joshtrichards @sistemi-nv @solracsf @nfebe @susnux