Skip to content

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Jan 29, 2024

Summary

Extracted from #40633 as it made more sense to clean up OC\Setup completely.
Migrate from deprecated methods to OCP\Server::get and DI.

Checklist

@come-nc come-nc added the 2. developing Work in progress label Jan 29, 2024
@come-nc come-nc self-assigned this Jan 29, 2024
@come-nc come-nc force-pushed the fix/use-di-for-setup-class branch from 2d2d3c5 to ccc66e9 Compare January 29, 2024 14:28
@come-nc come-nc added this to the Nextcloud 29 milestone Jan 29, 2024
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 30, 2024
@come-nc come-nc requested review from a team, Altahrim, ArtificialOwl, ChristophWurst, icewind1991 and nickvergessen and removed request for a team January 30, 2024 08:28
Comment on lines +389 to 392
if ($installPath === null) {
$this->isInstanceReadyForUpdates = false;
} else {
$this->isInstanceReadyForUpdates = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
if ($installPath === null) {
$this->isInstanceReadyForUpdates = false;
} else {
$this->isInstanceReadyForUpdates = true;
$this->isInstanceReadyForUpdates = $installPath !== null;

@come-nc come-nc merged commit 6533431 into master Jan 30, 2024
@come-nc come-nc deleted the fix/use-di-for-setup-class branch January 30, 2024 10:10
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants