Skip to content

feature(files): Hide breadcrumbs when an upload is ongoing on narrow screen #40942 #43325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 3 commits into from
Feb 26, 2024
Merged

feature(files): Hide breadcrumbs when an upload is ongoing on narrow screen #40942 #43325

skjnldsv merged 3 commits into from
Feb 26, 2024

Conversation

@arublov
Copy link
Member

@arublov arublov commented Feb 4, 2024

@arublov arublov requested a review from skjnldsv as a code owner February 4, 2024 01:23
@arublov arublov mentioned this pull request Feb 4, 2024
Closed
@arublov arublov changed the title feature: Hide breadcrumbs when an upload is ongoing on narrow screen #40942 feature(files): Hide breadcrumbs when an upload is ongoing on narrow screen #40942 Feb 4, 2024
@susnux susnux requested review from a team, nfebe and szaimen and removed request for a team February 4, 2024 13:23
@susnux susnux modified the milestones: Nextcloud 28.0.3, Nextcloud 29 Feb 4, 2024
skjnldsv
skjnldsv reviewed Feb 4, 2024
View reviewed changes
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 5, 2024
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv force-pushed the feature/hide-breadcrumbs-upload-and-overlap branch 2 times, most recently from 32bd3a3 to b09bf71 Compare February 23, 2024 20:36
@skjnldsv
Copy link
Member

skjnldsv commented Feb 23, 2024

/compile

@skjnldsv
Copy link
Member

skjnldsv commented Feb 23, 2024

please rebase and compile assets :)

@skjnldsv skjnldsv added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Feb 23, 2024
@arublov arublov force-pushed the feature/hide-breadcrumbs-upload-and-overlap branch from b09bf71 to b1f97b2 Compare February 24, 2024 21:47
@skjnldsv skjnldsv enabled auto-merge February 25, 2024 11:38
auto-merge was automatically disabled February 25, 2024 12:39

Head branch was pushed to by a user without write access

arublov and others added 2 commits February 25, 2024 13:40
@arublov @skjnldsv
Update apps/files/src/components/BreadCrumbs.vue
1c316c2 
Co-authored-by: John Molakvoæ <[email protected]>
Signed-off-by: Andrii Rublov <[email protected]>
@arublov
Builded assets
66f55d5 
Signed-off-by: Andrii Rublov <[email protected]>
@arublov arublov force-pushed the feature/hide-breadcrumbs-upload-and-overlap branch from 4796da2 to 66f55d5 Compare February 25, 2024 12:40
@arublov
Copy link
Member Author

arublov commented Feb 25, 2024

@skjnldsv , sorry for the delay, assets have now been pushed and rebased branch.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Feb 26, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Feb 26, 2024

/backport to stable28

@skjnldsv skjnldsv merged commit 027895f into nextcloud:master Feb 26, 2024
@welcome
Copy link

welcome bot commented Feb 26, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot backportbot bot mentioned this pull request Feb 26, 2024
Merged
2 tasks
@mejo- mejo- mentioned this pull request Feb 26, 2024
Merged
@arublov arublov deleted the feature/hide-breadcrumbs-upload-and-overlap branch February 26, 2024 13:08
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfebe nfebe nfebe approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

[F2V] Hide breadcrumbs when an upload is ongoing on narrow screen

4 participants

@arublov @skjnldsv @nfebe @susnux