Skip to content

Add rel attribute for fediverse link to make verification possible. #43364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Schnoop wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add rel attribute for fediverse link to make verification possible. #43364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95e09c7
Add rel tag for ferdiverse link to make verification possible.
Schnoop Feb 5, 2024
720c8a1
Merge branch 'master' into feature/fediverse
Schnoop Feb 5, 2024
bfc0d60
Merge branch 'master' into feature/fediverse
Schnoop Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/src/views/Profile.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
class="user-actions__primary"
:href="primaryAction.target"
:icon="primaryAction.icon"
:target="primaryAction.id === 'phone' ? '_self' :'_blank'">
:target="primaryAction.id === 'phone' ? '_self' :'_blank'"
:rel="primaryAction.id === 'fediverse' ? 'me': null">
Copy link
Contributor

@susnux susnux Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:rel="primaryAction.id === 'fediverse' ? 'me': null">
:rel="primaryAction.id === 'fediverse' ? 'me': undefined">

I think this makes it more clear and we use it like this on other places

<template #icon>
<!-- Fix for https://github.com/nextcloud-libraries/nextcloud-vue/issues/2315 -->
<img :src="primaryAction.icon" alt="" class="user-actions__primary__icon">
Expand All @@ -80,7 +81,8 @@
:key="action.id"
:close-after-click="true"
:href="action.target"
:target="action.id === 'phone' ? '_self' :'_blank'">
:target="action.id === 'phone' ? '_self' :'_blank'"
:rel="action.id === 'fediverse' ? 'me': null">
<template #icon>
<!-- Fix for https://github.com/nextcloud-libraries/nextcloud-vue/issues/2315 -->
<img :src="action.icon" alt="" class="user-actions__other__icon">
Expand Down
Loading