Skip to content

feature(files) : Give a hint that names starting with dots might be hidden #43366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arublov wants to merge 1 commit into from
Closed

feature(files) : Give a hint that names starting with dots might be hidden #43366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion apps/files/src/components/FileEntry/FileEntryName.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,12 @@ export default Vue.extend({
}
},

data() {
return {
isConfirmationFileCanHidden: false,
}
},

computed: {
isRenaming() {
return this.renamingStore.renamingNode === this.source
Expand Down Expand Up @@ -261,7 +267,7 @@ export default Vue.extend({
})
},
stopRenaming() {
if (!this.isRenaming) {
if (!this.isRenaming || this.isConfirmationFileCanHidden) {
return
}

Expand Down Expand Up @@ -290,6 +296,35 @@ export default Vue.extend({
return
}

// Checking and displaying confirmation that a file can be hidden
if(/^\.{1,}.+$/.test(newName)){
const confirm = await new Promise<boolean>(resolve => {
this.isConfirmationFileCanHidden = true

OC.dialogs.confirmDestructive(
t('files', 'Are you sure you want to rename the file from {oldName} to {newName}? The file can be hidden.', { oldName, newName }),
t('files', 'Confirm renaming'),
{
type: OC.dialogs.YES_NO_BUTTONS,
confirm: 'Yes',
confirmClasses: 'error',
cancel: t('files', 'Cancel'),
},
(decision: boolean) => {
resolve(decision)
},
)
return
})

// If the user cancels, we don't continue and return focus to the file
if (confirm === false) {
return
}

this.isConfirmationFileCanHidden = false
}

// Set loading state
this.loading = 'renaming'
Vue.set(this.source, 'status', NodeStatus.LOADING)
Expand Down