Skip to content

[stable28] fix(settings): focus on federation scope after dialog #43388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuliaKirschenheuter merged 4 commits into from
Feb 6, 2024
Merged

[stable28] fix(settings): focus on federation scope after dialog #43388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
723cbcb
fix(settings): focus on trigger after federation scope dialog close
ShGKme Feb 5, 2024
95aecf6
techdebt(settings): mark visibility selects as label-outside
ShGKme Feb 5, 2024
528d69d
chore(assets): Recompile assets
ShGKme Feb 5, 2024
87dde68
chore(assets): Recompile assets
nextcloud-command Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/settings/src/components/PersonalInfo/ProfileVisibilitySection/VisibilityDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
:clearable="false"
:options="visibilityOptions"
:value="visibilityObject"
label-outside
@option:selected="onVisibilityChange" />
</div>
</template>
Expand Down
6 changes: 5 additions & 1 deletion apps/settings/src/components/PersonalInfo/shared/FederationControl.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
-->

<template>
<NcActions class="federation-actions"
<NcActions ref="federationActions"
class="federation-actions"
:class="{ 'federation-actions--additional': additional }"
:aria-label="ariaLabel"
:default-icon="scopeIcon"
Expand Down Expand Up @@ -151,6 +152,9 @@ export default {
} else {
await this.updateAdditionalScope(scope)
}

// TODO: provide focus method from NcActions
this.$refs.federationActions.$refs.menuButton.$el.focus()
},

async updatePrimaryScope(scope) {
Expand Down
4 changes: 2 additions & 2 deletions dist/settings-vue-settings-personal-info.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings-vue-settings-personal-info.js.map
View file
Open in desktop

Large diffs are not rendered by default.