Skip to content

[stable28] fix: added last two places for aria-labels on setting icons #43403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 1 commit into from
Feb 6, 2024
Merged

[stable28] fix: added last two places for aria-labels on setting icons #43403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: added last two places for aria-labels on setting icons 
Signed-off-by: Eduardo Morales <[email protected]>
  • Loading branch information
@emoral435 @backportbot
emoral435 authored and backportbot[bot] committed Feb 6, 2024
commit 4b40638d00641e01a080acec1af0eb49f020b149
8 changes: 5 additions & 3 deletions apps/settings/templates/settings/admin/additional-mail.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,11 @@
<div class="section" id="mail_general_settings">
<form id="mail_general_settings_form" class="mail_settings">
<h2><?php p($l->t('Email server'));?></h2>
<a target="_blank" rel="noreferrer noopener" class="icon-info"
title="<?php p($l->t('Open documentation'));?>"
href="<?php p(link_to_docs('admin-email')); ?>"></a>
<a target="_blank"
rel="noreferrer noopener" class="icon-info"
title="<?php p($l->t('Open documentation'));?>"
href="<?php p(link_to_docs('admin-email')); ?>"
aria-label="<?php p($l->t('Open documentation'));?>"></a>
<p class="settings-hint">
<?php p($l->t('It is important to set up this server to be able to send emails, like for password reset and notifications.')); ?>
</p>
Expand Down
7 changes: 6 additions & 1 deletion apps/settings/templates/settings/admin/overview.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@
<div id="security-warning" class="section">
<div class="security-warning__heading">
<h2><?php p($l->t('Security & setup warnings'));?></h2>
<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation'));?>" href="<?php p(link_to_docs('admin-warnings')); ?>"></a>
<a target="_blank"
rel="noreferrer"
class="icon-info"
title="<?php p($l->t('Open documentation'));?>"
href="<?php p(link_to_docs('admin-warnings')); ?>"
aria-label="<?php p($l->t('Open documentation')); ?>"></a>
</div>
<p class="settings-hint"><?php p($l->t('It\'s important for the security and performance of your instance that everything is configured correctly. To help you with that we are doing some automatic checks. Please see the linked documentation for more information.'));?></p>

Expand Down