Skip to content

do not break personal settings page is viewer is not there #43435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szaimen merged 2 commits into from
Feb 8, 2024
Merged

do not break personal settings page is viewer is not there #43435

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0c57ed
do not break personal settings page is viewer is not there
szaimen Feb 7, 2024
686e268
fix psalm
szaimen Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
do not break personal settings page is viewer is not there 
Signed-off-by: Simon L <[email protected]>
  • Loading branch information
@szaimen
szaimen committed Feb 7, 2024
commit b0c57ed65fe419674ce8eaf080996f3a96833263
7 changes: 2 additions & 5 deletions apps/settings/lib/Settings/Personal/ServerDevNotice.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,8 @@ public function getForm(): TemplateResponse {

$hasInitialState = false;

// viewer is default enabled and this makes a zero-cost assertion for Psalm
assert(class_exists(LoadViewer::class));

// If the Reasons to use Nextcloud.pdf file is here, let's init Viewer
if ($userFolder->nodeExists('Reasons to use Nextcloud.pdf')) {
// If the Reasons to use Nextcloud.pdf file is here, let's init Viewer, also check that Viewer is there
if (class_exists(LoadViewer::class) && $userFolder->nodeExists('Reasons to use Nextcloud.pdf')) {
$this->eventDispatcher->dispatch(LoadViewer::class, new LoadViewer());
$hasInitialState = true;
}
Expand Down