Skip to content

feat: add PATCH HTTP Verb Support To IClient Interface & its HTTP Client Implementation #43446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Mar 16, 2024
Merged

feat: add PATCH HTTP Verb Support To IClient Interface & its HTTP Client Implementation #43446

skjnldsv merged 2 commits into from
Mar 16, 2024

Conversation

@jithin-space
Copy link

@jithin-space jithin-space commented Feb 8, 2024 •
edited by ChristophWurst
Loading

Summary

Added PATCH HTTP Verb Support To IClient Interface & its HTTP Client Implementation

Closes #43450

TODO

  • N/A

Checklist

added patch method
7c11414 
Signed-off-by: jithin-space <[email protected]>
@jithin-space jithin-space mentioned this pull request Feb 8, 2024
Closed
@joshtrichards joshtrichards linked an issue Feb 8, 2024 that may be closed by this pull request
Add Patch Support in the Http Client Implementation #43450
Closed
@joshtrichards joshtrichards added 3. to review Waiting for reviews enhancement labels Feb 8, 2024
@solracsf solracsf changed the title Added PATCH HTTP Verb Support To IClient Interface & its HTTP Client Implementation feat: add PATCH HTTP Verb Support To IClient Interface & its HTTP Client Implementation Mar 10, 2024
nickvergessen
nickvergessen reviewed Mar 10, 2024
View reviewed changes
@ChristophWurst ChristophWurst added this to the Nextcloud 30 milestone Mar 14, 2024
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Mar 14, 2024
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2024
@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 14, 2024

@nickvergessen do we really want to merge after API freeze?

@nickvergessen
Copy link
Member

nickvergessen commented Mar 14, 2024

It's a pure addition, so I'd be fine.
But yeah following the rules it'd be 30, but that would mean the app can not be released in the meantime or they need to privately access Guzzle skipping all the security measurements we build in, so I'm a bit drawn apart.

@Altahrim Altahrim mentioned this pull request Mar 14, 2024
Merged
@skjnldsv skjnldsv merged commit 836c882 into nextcloud:master Mar 16, 2024
@welcome
Copy link

welcome bot commented Mar 16, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@Altahrim Altahrim mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement pending documentation This pull request needs an associated documentation update

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

Add Patch Support in the Http Client Implementation

5 participants

@jithin-space @ChristophWurst @nickvergessen @joshtrichards @skjnldsv