Skip to content

[stable28] fix(files): move focus to sidebar on open #43448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShGKme merged 3 commits into from
Feb 8, 2024
Merged

[stable28] fix(files): move focus to sidebar on open #43448

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78a7f74
fix(files): do not disable action on load to keep focus
ShGKme Feb 6, 2024
b395865
fix(files): focus sidebar tab on tab or file change
ShGKme Feb 6, 2024
33c7f9b
chore(assets): Recompile assets
ShGKme Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): do not disable action on load to keep focus 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
  • Loading branch information
@ShGKme @backportbot
ShGKme authored and backportbot[bot] committed Feb 8, 2024
commit 78a7f7435783763c7f5ee8f549b2ec322cecd9a8
6 changes: 5 additions & 1 deletion apps/files/src/components/FileEntry/FileEntryActions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
<NcActions ref="actionsMenu"
:boundaries-element="getBoundariesElement"
:container="getBoundariesElement"
:disabled="isLoading || loading !== ''"
:force-name="true"
type="tertiary"
:force-menu="enabledInlineActions.length === 0 /* forceMenu only if no inline actions */"
Expand Down Expand Up @@ -272,6 +271,11 @@ export default Vue.extend({
},

async onActionClick(action, isSubmenu = false) {
// Skip click on loading
if (this.isLoading || this.loading !== '') {
return
}

// If the action is a submenu, we open it
if (this.enabledSubmenuActions[action.id]) {
this.openedSubmenu = action
Expand Down