fix(userstatus): add back 0 timestamp for status without message #43464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable28 |
Antreesy
approved these changes
Feb 12, 2024
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Seems to be the same code as in fix before 👀 Let's try it
ChristophWurst
added
the
4. to release
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/43089/empty-dashboard-userstatus
branch
from
34d17af to
c071fbf
Compare
Contributor
Author
|
Drone failure unrelated @ChristophWurst can I haz force merge? |
Member
|
Could/should we add a unit test to have the case documented properly to avoid another back and forth when something else is misbehaving again? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When updating a status from automation, the old code set a timestamp for an empty message status such as DND updates for status automation.
Checklist