Skip to content

[Bugfix]: 'forbidden_chars' - the condition added for uploading via Drop or UploadPicker. #43495 #43512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arublov wants to merge 8 commits into from
Closed

[Bugfix]: 'forbidden_chars' - the condition added for uploading via Drop or UploadPicker. #43495 #43512

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bd483b7
[Bugfix]: 'forbidden_chars' - the condition added for uploading via D…
Feb 10, 2024
d02ce26
Update apps/files/src/services/DropService.ts
arublov Feb 13, 2024
5e0ae97
Update apps/files/src/services/DropService.ts
arublov Feb 13, 2024
f684766
Update apps/files/src/services/DropService.ts
arublov Feb 13, 2024
1fc8e6e
Code refactoring
Feb 13, 2024
935922c
Update DropService.ts
arublov Feb 13, 2024
bfcc036
Update apps/files/src/services/DropService.ts
arublov Feb 13, 2024
27d96c3
Refactor code - move forbiddenCharacters from computed to data
Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update apps/files/src/services/DropService.ts 
Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Andrii Rublov <[email protected]>
  • Loading branch information
@arublov @susnux
arublov and susnux authored Feb 13, 2024
commit d02ce2616c7f82007a43f08d75fe971dd00669cc
2 changes: 1 addition & 1 deletion apps/files/src/services/DropService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const handleFileUpload = async (file: File, path: string = '') => {
let forbiddenChar

if(forbiddenChar = forbidden.find(char => file.name.includes(char))){
showError(t('files', `"${forbiddenChar}" is not allowed inside a file name.`));
showError(t('files', '"{forbiddenChar}" is not allowed inside a file name.', { forbiddenChar }))
}else{
try {
return await uploader.upload(`${path}${file.name}`, file)
Expand Down