Skip to content

[stable28] Fix Slow logout on Chrome-like browsers #43525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 4 commits into from
Feb 22, 2024
Merged

[stable28] Fix Slow logout on Chrome-like browsers #43525

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7418c3e
Cancel PR #37405, remove regression code
HLFH Jan 2, 2024
7e7a4dd
Keep https check
HLFH Jan 4, 2024
c1ef86c
Fix tests after slow logout fix
artonge Jan 8, 2024
3decdd9
fix(tests): Fix remaining tests
nickvergessen Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Keep https check 
#41196 + keep https check

Co-authored-by: Louis <[email protected]>
Signed-off-by: Gaspard d'Hautefeuille <[email protected]>
  • Loading branch information
@HLFH @artonge @skjnldsv
2 people authored and skjnldsv committed Feb 22, 2024
commit 7e7a4ddd5c0b748a2016efc72718cd9d01cc67db
5 changes: 4 additions & 1 deletion core/Controller/LoginController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@ public function logout() {
$this->session->set('clearingExecutionContexts', '1');
$this->session->close();

if (!$this->request->isUserAgent([Request::USER_AGENT_CHROME, Request::USER_AGENT_ANDROID_MOBILE_CHROME])) {
if (
$this->request->getServerProtocol() === 'https' &&
!$this->request->isUserAgent([Request::USER_AGENT_CHROME, Request::USER_AGENT_ANDROID_MOBILE_CHROME])
) {
$response->addHeader('Clear-Site-Data', '"cache", "storage"');
}

Expand Down