only cleanup orphaned shared daily #43605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
nfebe,
nickvergessen and
sorbaugh
and removed request for
a team
4 tasks
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
orphan-share-daily
branch
from
6714fd0 to
0b8f0d0
Compare
juliusknorr
approved these changes
Feb 16, 2024
joshtrichards
approved these changes
Feb 17, 2024
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Since we filter out the shares with no matching files when loading them already
You had me at this. :-)
Makes sense.
Member
|
/backport to stable28 |
Member
|
/backport to stable27 |
Member
|
/backport to stable26 |
2 tasks
This was referenced Feb 26, 2024
Merged
3 tasks
8 tasks
|
I've seen with Nextcloud 31, cron task does not remove orphan shares. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we filter out the shares with no matching files when loading them already there is no real downsides to leaving them in the db a bit longer.
Reducing the interval should decrease the db load a bit