Skip to content

Conversation

@hardviper
Copy link

@hardviper hardviper commented Feb 20, 2024

Summary

This solves the oAuth2 authorization issue in openproject when openproject is the client.
Added endpoint that returns a minimum set of user information.
This is very necessary in my openproject integration with nextcloud.
I hope this helps someone else.
Thanks to @jlallana for suggesting this solution in PR #19934.

Checklist

@hardviper hardviper force-pushed the feat/oauth2/userinfo branch from e7d19eb to f5b90e2 Compare February 20, 2024 11:36
@hardviper hardviper marked this pull request as draft February 20, 2024 12:26
@hardviper hardviper marked this pull request as ready for review February 20, 2024 12:26
@skjnldsv skjnldsv added the 2. developing Work in progress label Feb 21, 2024
@hardviper
Copy link
Author

@skjnldsv Is there anything else I can add to help you accept this?

@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Feb 21, 2024
@skjnldsv
Copy link
Member

@skjnldsv Is there anything else I can add to help you accept this?

I pinged the proper devs, let's see :)
Does this supersede #19934 ?

@hardviper
Copy link
Author

@skjnldsv This adds the user_info endpoint, but does not add the discovery.
Now I have fixed the problem noted by the bot, and also added some more userinfo fields.

@hardviper hardviper force-pushed the feat/oauth2/userinfo branch from 6b373db to d934c98 Compare February 21, 2024 20:48
@hardviper hardviper requested a review from skjnldsv as a code owner February 21, 2024 20:48
@skjnldsv
Copy link
Member

There was an issue with the rebase, please fix it

@hardviper hardviper force-pushed the feat/oauth2/userinfo branch from d934c98 to 21a1825 Compare February 22, 2024 09:25
@hardviper
Copy link
Author

@skjnldsv Ready! I have corrected! I don't understand how these commits got here.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the endpoint. Some instructions for testing would be appreciated.

The name split logic probably doesn't work for all names. If we can I would strongly favor removing it and only exposing the full name.

@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Mar 28, 2024
@kesselb
Copy link
Contributor

kesselb commented Mar 28, 2024

Is there an addition of last name and first name fields in the roadmap?

Forwarded your question.
Please ping me if we haven't replied within the next 4 weeks.

@hardviper
Copy link
Author

@kesselb Do you have an answer for the roadmap?

@kesselb
Copy link
Contributor

kesselb commented Jun 3, 2024

Do you have an answer for the roadmap?

Having fields for first name, last name, title or prefix as addition/replacement for the full name field is something we want.

However, it's not scheduled for the current or next iteration.

https://github.com/H2CK/oidc could be interesting for you as well.

This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@blizzz blizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
@blizzz blizzz mentioned this pull request Jan 29, 2025
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
This was referenced Aug 22, 2025
This was referenced Sep 2, 2025
This was referenced Sep 25, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants