Skip to content

feat(tests): Test that mtime is the same after move or rename #43689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
come-nc wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

feat(tests): Test that mtime is the same after move or rename #43689

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
531ec42
feat(tests): Test that mtime is the same after move or rename
come-nc Feb 20, 2024
56918bf
fix(tests): Alter mtime to be in the past before checking it was pres…
come-nc Feb 20, 2024
d176d3c
fix: Fix mtime preservation on rename in KnownMtime wrapper
come-nc Feb 20, 2024
ad68b06
feat(tests): Add test for moveFromStorage
come-nc Feb 22, 2024
afcbdf5
fix(tests): Fix moveFromStorage test for encryption wrapper
come-nc Feb 22, 2024
a9c3a14
fix(files): Fix mtime preservation in Local and Common storages
come-nc Feb 22, 2024
f9b4cf4
fix(files): Preserve directory mtime on rename and move
come-nc Feb 22, 2024
d37436a
fix: Update children classes of Common to respect copy signature
come-nc Feb 22, 2024
c412f34
fixup! fix: Update children classes of Common to respect copy signature
come-nc Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Fix mtime preservation on rename in KnownMtime wrapper 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Feb 22, 2024
commit d176d3cd9a55c2c4a643bc7672bbd8a5e2d6d6f9
5 changes: 3 additions & 2 deletions lib/private/Files/Storage/Wrapper/KnownMtime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function unlink($path) {
public function rename($source, $target) {
$result = parent::rename($source, $target);
if ($result) {
$this->knowMtimes->set($target, $this->clock->now()->getTimestamp());
$this->knowMtimes->set($target, $this->filemtime($source));
$this->knowMtimes->set($source, $this->clock->now()->getTimestamp());
}
return $result;
Expand Down Expand Up @@ -125,9 +125,10 @@ public function copyFromStorage(IStorage $sourceStorage, $sourceInternalPath, $t
}

public function moveFromStorage(IStorage $sourceStorage, $sourceInternalPath, $targetInternalPath) {
$mTime = $sourceStorage->filemtime($sourceInternalPath);
$result = parent::moveFromStorage($sourceStorage, $sourceInternalPath, $targetInternalPath);
if ($result) {
$this->knowMtimes->set($targetInternalPath, $this->clock->now()->getTimestamp());
$this->knowMtimes->set($targetInternalPath, $mTime);
}
return $result;
}
Expand Down