fix(dav): Rate limit calendar/subscription creation #43732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
miaulalala and
tcitworld
as code owners
ChristophWurst
commented
Feb 21, 2024
| throw new TooManyRequests('Too many calendars created', 0, $e); | ||
| } | ||
|
|
||
| $calendarLimit = $this->config->getValueInt('dav', 'maximum_calendars', 30); |
Member
Author
There was a problem hiding this comment.
I'm open for input on a reasonable limit for 99% of users. someone will exceed it and they need the admin to increase the limit. this is acceptable.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tcitworld
reviewed
Feb 21, 2024
Member
tcitworld
left a comment
tcitworld
left a comment
There was a problem hiding this comment.
Did you test how the Calendar app currently handles the TooManyRequests exception? When creating calendars/subscriptions/holiday calendars/imports
Mind creating an issue to make sure this is tracked?
Member
Author
Sure! nextcloud/calendar#5792 |
ChristophWurst
force-pushed
the
fix/dav/rate-limit-create-calendar
branch
from
7f07be8 to
9bfa1a3
Compare
tcitworld
approved these changes
Feb 22, 2024
ChristophWurst
added
4. to release
This was referenced Feb 22, 2024
Merged
Merged
Merged
Member
Author
|
/backport! to stable28 |
Member
Author
|
/backport! to stable27 |
Member
Author
|
/backport! to stable26 |
2 tasks
This was referenced Feb 22, 2024
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/dav/rate-limit-create-calendar
branch
from
9bfa1a3 to
dc7f2ba
Compare
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds rate limiting for new calendars and subscriptions.
Checklist