Skip to content

fix(files): page h1 heading #43784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShGKme merged 2 commits into from
Feb 23, 2024
Merged

fix(files): page h1 heading #43784

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f12d36b
fix(files): page h1 heading
ShGKme Feb 23, 2024
e7361df
chore(assets): Recompile assets
ShGKme Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): page h1 heading 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
  • Loading branch information
@ShGKme
ShGKme committed Feb 23, 2024
commit f12d36b2269af4ed57462e331646d63b131fc091
8 changes: 6 additions & 2 deletions apps/files/src/views/FilesList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
-
-->
<template>
<NcAppContent data-cy-files-content>
<NcAppContent :page-heading="pageHeading" data-cy-files-content>
<div class="files-list__header">
<!-- Current folder breadcrumbs -->
<BreadCrumbs :path="dir" @reload="fetchContent">
Expand Down Expand Up @@ -225,6 +225,10 @@ export default defineComponent({
return this.$navigation.active || this.$navigation.views.find((view) => view.id === (this.$route.params?.view ?? 'files'))
},

pageHeading(): string {
return this.currentView?.name ?? this.t('files', 'Files')
},

/**
* The current directory query.
*/
Expand Down Expand Up @@ -567,7 +571,7 @@ export default defineComponent({
* Refreshes the current folder on update.
*
* @param node is the file/folder being updated.
*/
*/
onUpdatedNode(node?: Node) {
if (node?.fileid === this.currentFolder?.fileid) {
this.fetchContent()
Expand Down
2 changes: 0 additions & 2 deletions apps/files/src/views/Navigation.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ import NcAppNavigation from '@nextcloud/vue/dist/Components/NcAppNavigation.js'
import NcAppNavigationItem from '@nextcloud/vue/dist/Components/NcAppNavigationItem.js'
import NcIconSvgWrapper from '@nextcloud/vue/dist/Components/NcIconSvgWrapper.js'

import { setPageHeading } from '../../../../core/src/OCP/accessibility.js'
import { useViewConfigStore } from '../store/viewConfig.ts'
import logger from '../logger.js'
import NavigationQuota from '../components/NavigationQuota.vue'
Expand Down Expand Up @@ -187,7 +186,6 @@ export default {
// Closing any opened sidebar
window?.OCA?.Files?.Sidebar?.close?.()
this.$navigation.setActive(view)
setPageHeading(view.name)
emit('files:navigation:changed', view)
},

Expand Down