Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(files): fixed breadcrumbs dissapearing on narrow screens
Signed-off-by: Eduardo Morales <[email protected]>
  • Loading branch information
emoral435 authored and skjnldsv committed Apr 4, 2024
commit e22b67d02c98e691327985624f01e561f4ac10ab
54 changes: 38 additions & 16 deletions apps/files/src/components/BreadCrumbs.vue
Original file line number Diff line number Diff line change
@@ -1,3 +1,25 @@
<!--
- @copyright Copyright (c) 2023 John Molakvoæ <[email protected]>
-
- @author John Molakvoæ <[email protected]>
-
- @license AGPL-3.0-or-later
-
- This program is free software: you can redistribute it and/or modify
- it under the terms of the GNU Affero General Public License as
- published by the Free Software Foundation, either version 3 of the
- License, or (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU Affero General Public License for more details.
-
- You should have received a copy of the GNU Affero General Public License
- along with this program. If not, see <http://www.gnu.org/licenses/>.
-
-->

<template>
<NcBreadcrumbs
data-cy-files-content-breadcrumbs
Expand Down Expand Up @@ -29,11 +51,10 @@
</template>

<script lang="ts">
import type { Node } from '@nextcloud/files'
import { Permission, type Node } from '@nextcloud/files'

import { basename } from 'path'
import { defineComponent } from 'vue'
import { Permission } from '@nextcloud/files'
import { translate as t} from '@nextcloud/l10n'
import HomeSvg from '@mdi/svg/svg/home.svg?raw'
import NcBreadcrumb from '@nextcloud/vue/dist/Components/NcBreadcrumb.js'
Expand Down Expand Up @@ -91,12 +112,12 @@ export default defineComponent({
return this.$navigation.active
},

dirs() {
const cumulativePath = (acc) => (value) => (acc += `${value}/`)
dirs(): string[] {
const cumulativePath = (acc: string) => (value: string) => (acc += `${value}/`)
// Generate a cumulative path for each path segment: ['/', '/foo', '/foo/bar', ...] etc
const paths = this.path.split('/').filter(Boolean).map(cumulativePath('/'))
const paths: string[] = this.path.split('/').filter(Boolean).map(cumulativePath('/'))
// Strip away trailing slash
return ['/', ...paths.map(path => path.replace(/^(.+)\/$/, '$1'))]
return ['/', ...paths.map((path: string) => path.replace(/^(.+)\/$/, '$1'))]
},

sections() {
Expand All @@ -114,11 +135,6 @@ export default defineComponent({
})
},

// used to show the views icon for the first breadcrumb
viewIcon() {
return this.currentView?.icon ?? HomeSvg
},

isUploadInProgress(): boolean {
return this.uploaderStore.queue.length !== 0
},
Expand All @@ -134,6 +150,11 @@ export default defineComponent({
return this.filesListWidth > 400
},

// used to show the views icon for the first breadcrumb
viewIcon(): string {
return this.currentView?.icon ?? HomeSvg
},

selectedFiles() {
return this.selectionStore.selected
},
Expand All @@ -144,19 +165,19 @@ export default defineComponent({
},

methods: {
getNodeFromId(id) {
getNodeFromId(id: number): Node | undefined {
return this.filesStore.getNode(id)
},
getFileIdFromPath(path) {
getFileIdFromPath(path: string): number | undefined {
return this.pathsStore.getPath(this.currentView?.id, path)
},
getDirDisplayName(path) {
getDirDisplayName(path: string): string {
if (path === '/') {
return this.$navigation?.active?.name || t('files', 'Home')
}

const fileId = this.getFileIdFromPath(path)
const node = this.getNodeFromId(fileId)
const fileId: number | undefined = this.getFileIdFromPath(path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not get why hard coding this is needed instead of implicit type from function return?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea 😅
I don't recall when I added this. Might have had a brain Zapp 🙃

const node: Node | undefined = (fileId) ? this.getNodeFromId(fileId) : undefined
return node?.attributes?.displayName || basename(path)
},

Expand Down Expand Up @@ -263,6 +284,7 @@ export default defineComponent({
// Take as much space as possible
flex: 1 1 100% !important;
width: 100%;
margin-inline: 0px 10px 0px 10px;

::v-deep a {
cursor: pointer !important;
Expand Down
4 changes: 2 additions & 2 deletions dist/files-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-main.js.map

Large diffs are not rendered by default.