Add ability to cancel a scheduled transcription #43862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
added
enhancement
3. to review
marcelklehr
approved these changes
Feb 27, 2024
julien-nc
requested review from
a team,
ArtificialOwl,
nfebe and
sorbaugh
and removed request for
a team
Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
enh/cancel-stt-scheduled-transcription
branch
from
3e4fa22 to
76925f1
Compare
Altahrim
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to cancel a scheduled transcription given the same information provided to schedule it.
We don't get the job ID when adding the job in the jobList. Even if we did, it is not possible to use job IDs to remove a job from the list.