Skip to content

[stable28] fix(files): fix html structure on the profile page #43909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShGKme merged 2 commits into from
Mar 4, 2024
Merged

[stable28] fix(files): fix html structure on the profile page #43909

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5f9573
fix(files): fix html structure on pre profile page
JuliaKirschenheuter Feb 28, 2024
6741394
chore(assets): Recompile assets
nextcloud-command Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): fix html structure on pre profile page 
Signed-off-by: julia.kirschenheuter <[email protected]>
  • Loading branch information
@JuliaKirschenheuter @Pytal
JuliaKirschenheuter authored and Pytal committed Mar 4, 2024
commit f5f957336f24c976d14aef527021e59e383662ed
4 changes: 1 addition & 3 deletions apps/settings/src/components/PersonalInfo/AvatarSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@

<template>
<section id="vue-avatar-section">
<h3 class="hidden-visually">
{{ t('settings', 'Your profile information') }}
</h3>
<HeaderBar :is-heading="true"
:readable="avatar.readable"
:scope.sync="avatar.scope" />
Expand Down Expand Up @@ -275,6 +272,7 @@ export default {
<style lang="scss" scoped>
section {
grid-row: 1/3;
padding: 10px 10px;
}
.avatar {
&__container {
Expand Down
8 changes: 4 additions & 4 deletions apps/settings/src/components/PersonalInfo/shared/HeaderBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
-->

<template>
<component :is="isHeading ? `h3` : `div`" class="headerbar-label" :class="{ 'setting-property': isSettingProperty, 'profile-property': isProfileProperty }">
<span v-if="isHeading">
<div class="headerbar-label" :class="{ 'setting-property': isSettingProperty, 'profile-property': isProfileProperty }">
<h3 v-if="isHeading">
<!-- Already translated as required by prop validator -->
{{ readable }}
</span>
</h3>
<label v-else :for="inputId">
<!-- Already translated as required by prop validator -->
{{ readable }}
Expand All @@ -49,7 +49,7 @@
{{ t('settings', 'Add') }}
</NcButton>
</template>
</component>
</div>
</template>

<script>
Expand Down