Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 3, 2024

Summary

This provides information on what changed on an app update for users:
If notifications are enabled users will receive a notification for an app update if that app is enabled for that user.
The update notification is only provided if a changelog exists, to allow technical changelog and user changelogs following logic is applied:
As per appstore documentation CHANGELOG.md is used for technical changelogs (e.g. developers or administrators).
For users the CHANGELOG.{code}.md file is used ({code} is the language code), and it falls back to CHANGELOG.en.md if the requested language is missing.

Meaning: For user changelog CHANGELOG.{lang}.md with fallback CHANGELOG.en.md is used, for admins or developers use CHANGELOG.md.

Screen cast

vokoscreenNG-2024-03-03_18-34-33.mp4

TODO

  • Add app config options to admin docs
  • Would be nice to have unit tests.

Checklist

@susnux susnux force-pushed the feat/app-updated-notification branch from 0cce43a to 8433293 Compare March 3, 2024 21:47
@susnux susnux force-pushed the feat/app-updated-notification branch 3 times, most recently from faccee1 to 2dd3d58 Compare March 4, 2024 17:04
@susnux susnux force-pushed the feat/app-updated-notification branch 2 times, most recently from c1bd12b to f9b9ff5 Compare March 4, 2024 23:04
@susnux susnux force-pushed the feat/app-updated-notification branch from f9b9ff5 to 5f9c835 Compare March 4, 2024 23:51
@susnux susnux force-pushed the feat/app-updated-notification branch from 5f9c835 to f36c45d Compare March 5, 2024 10:58
@susnux susnux marked this pull request as ready for review March 5, 2024 11:05
@susnux susnux requested review from come-nc and emoral435 March 5, 2024 11:05
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 5, 2024
@susnux susnux requested review from artonge and sorbaugh March 5, 2024 11:07
@susnux
Copy link
Contributor Author

susnux commented Mar 5, 2024

How to test?
Install and enable the "QA testing" app, then add a CHANGELOG.en.md to the testing app folder, increase the version number in appinfo and run the update in nextcloud -> see changes notification.

@susnux susnux force-pushed the feat/app-updated-notification branch 4 times, most recently from c1e8013 to fc55c75 Compare March 7, 2024 18:28
susnux added 8 commits March 7, 2024 22:40
…jobs into `BackgroundJobs` subfolder

Signed-off-by: Ferdinand Thiessen <[email protected]>
…dated

* Open app changelog dialog when available (webui)
* Fallback to open changelog page for mobile clients

Signed-off-by: Ferdinand Thiessen <[email protected]>
…amed background jobs

This can be dropped with Nextcloud 30.

Signed-off-by: Ferdinand Thiessen <[email protected]>
…ons and allow to en/disable guest users notification

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@skjnldsv skjnldsv force-pushed the feat/app-updated-notification branch from fc55c75 to b969eab Compare March 7, 2024 21:44
@skjnldsv skjnldsv merged commit cf888e9 into master Mar 7, 2024
@skjnldsv skjnldsv deleted the feat/app-updated-notification branch March 7, 2024 21:44
@susnux susnux mentioned this pull request May 6, 2024
5 tasks
@susnux susnux removed the pending documentation This pull request needs an associated documentation update label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants