-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: Provide app-updated notifications for users #43967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cce43a to
8433293
Compare
nickvergessen
requested changes
Mar 4, 2024
apps/updatenotification/lib/BackgroundJob/AppUpdatedNotifications.php
Outdated
Show resolved
Hide resolved
faccee1 to
2dd3d58
Compare
c1bd12b to
f9b9ff5
Compare
f9b9ff5 to
5f9c835
Compare
5f9c835 to
f36c45d
Compare
Contributor
Author
|
How to test? |
c1e8013 to
fc55c75
Compare
sorbaugh
approved these changes
Mar 7, 2024
AndyScherzinger
approved these changes
Mar 7, 2024
…jobs into `BackgroundJobs` subfolder Signed-off-by: Ferdinand Thiessen <[email protected]>
…dated * Open app changelog dialog when available (webui) * Fallback to open changelog page for mobile clients Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…amed background jobs This can be dropped with Nextcloud 30. Signed-off-by: Ferdinand Thiessen <[email protected]>
…ons and allow to en/disable guest users notification Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
fc55c75 to
b969eab
Compare
This was referenced Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This provides information on what changed on an app update for users:
If notifications are enabled users will receive a notification for an app update if that app is enabled for that user.
The update notification is only provided if a changelog exists, to allow technical changelog and user changelogs following logic is applied:
As per appstore documentation CHANGELOG.md is used for technical changelogs (e.g. developers or administrators).
For users the CHANGELOG.{code}.md file is used (
{code}is the language code), and it falls back to CHANGELOG.en.md if the requested language is missing.Meaning: For user changelog CHANGELOG.{lang}.md with fallback CHANGELOG.en.md is used, for admins or developers use CHANGELOG.md.
Screen cast
vokoscreenNG-2024-03-03_18-34-33.mp4
TODO
Checklist