Skip to content

feat: add pronouns to account profile #44013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Sep 17, 2024
Merged

feat: add pronouns to account profile #44013

skjnldsv merged 2 commits into from
Sep 17, 2024

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 5, 2024 •
edited
Loading

Fix #40017

Desktop Mobile
2024-09-17_23-32 2024-09-17_23-31

image
image

  • Add free text input to enter pronouns
  • Always show the pronouns next to the displayName

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 5, 2024
View reviewed changes
@skjnldsv skjnldsv force-pushed the fieat/profile-pronounces branch from bd95aa8 to 3d77190 Compare March 6, 2024 09:12
susnux
susnux reviewed Mar 6, 2024
View reviewed changes
@skjnldsv skjnldsv added 2. developing Work in progress feature: settings feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Mar 6, 2024
Pytal
Pytal reviewed Mar 7, 2024
View reviewed changes
Pytal

This comment was marked as resolved.

Sign in to view

@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Mar 7, 2024
@botsarenthuman

This comment was marked as off-topic.

Sign in to view
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 8, 2024
jancborchardt
jancborchardt approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, and looks good design-wise! They will also show in the visibility settings, right?

Can you show a screenshot how it will look like on the profile? I assume subline like the other things, possibly divided by the middle dot we often use? ·

@skjnldsv

This comment has been minimized.

Sign in to view
@botsarenthuman

This comment was marked as off-topic.

Sign in to view
@nextcloud nextcloud locked as too heated and limited conversation to collaborators Aug 8, 2024
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 8, 2024

It's just not the place to have a discussion on if a feature is controversial or not.
I'm proactively locking to not be distracted by future comments 🤟

@jancborchardt
Copy link
Member

jancborchardt commented Aug 8, 2024

Please make this optional, or opt-in

It's optional to put in pronouns, soo …

@skjnldsv skjnldsv force-pushed the fieat/profile-pronounces branch from d934fba to 64549d0 Compare September 17, 2024 20:05
@skjnldsv
feat: add profile pronouns
26abc86 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the fieat/profile-pronounces branch 3 times, most recently from 8a4e7c3 to 2e04ce6 Compare September 17, 2024 22:11
@skjnldsv
fix(core): profile design and pronouns support
b24e02e 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv force-pushed the fieat/profile-pronounces branch from 2e04ce6 to b24e02e Compare September 17, 2024 22:16
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 17, 2024

Let's go!! 🚀
I'll see how we can improve the user hover menu as a follow-up!

@skjnldsv skjnldsv requested review from Pytal and susnux and removed request for Pytal and susnux September 17, 2024 23:00
@skjnldsv skjnldsv requested review from a team, Pytal, artonge and susnux and removed request for a team September 17, 2024 23:00
@skjnldsv skjnldsv marked this pull request as ready for review September 17, 2024 23:00
@skjnldsv skjnldsv requested review from a team and removed request for provokateurin September 17, 2024 23:01
@skjnldsv skjnldsv added 3. to review Waiting for reviews inclusivity 🌈 and removed 2. developing Work in progress labels Sep 17, 2024
@skjnldsv skjnldsv enabled auto-merge September 17, 2024 23:15
Pytal
Pytal approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

No idea about LDAP part 🙈

core/src/views/Profile.vue
Comment on lines +441 to +442
// Overlap avatar to top header
margin-top: -110px !important;
Copy link
Member

@Pytal Pytal Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Overlap avatar to top header
margin-top: -110px !important;
// Overlap avatar to top header
margin-top: -110px !important;

@skjnldsv skjnldsv merged commit 6bcab26 into master Sep 17, 2024
@skjnldsv skjnldsv deleted the fieat/profile-pronounces branch September 17, 2024 23:25
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 17, 2024

Code looks good!

No idea about LDAP part 🙈

I'll double check with Arthur tomorrow :)

@come-nc
Copy link
Contributor

come-nc commented Sep 18, 2024

@skjnldsv This broke the tests but the CI was wrongly green.
Please do a follow-up PR to fix the related tests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@Pytal Pytal Pytal approved these changes

@artonge artonge Awaiting requested review from artonge

@susnux susnux Awaiting requested review from susnux susnux is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feature: settings inclusivity 🌈 🍀 2025-Spring

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

Allow setting third person pronouns in user's profile

8 participants

@skjnldsv @botsarenthuman @jancborchardt @come-nc @susnux @Pytal @AndyScherzinger