Skip to content

feat: show the id of last author in versions metadata #44049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emoral435 merged 7 commits into from
Mar 11, 2024
Merged

feat: show the id of last author in versions metadata #44049

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
88b40bb
feat: added metadata event listener
emoral435 Mar 9, 2024
b2c8554
feat: added backend metadata interface, allows JSON storage
emoral435 Mar 9, 2024
4cf4fdc
feat: exposed metadata column to frontend
emoral435 Mar 9, 2024
a8844d4
fix(files_version): deprecated INameableVersion
emoral435 Mar 11, 2024
c5d1fda
fix: fixed stylistic errors
emoral435 Mar 11, 2024
5c6be88
chore(assets): build autoloader
emoral435 Mar 11, 2024
bfacc6d
chore(assets): compile assets
emoral435 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fixed stylistic errors 
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
  • Loading branch information
@emoral435
emoral435 committed Mar 11, 2024
commit c5d1fda4ab1b8cd4058348b4d81a6d1cbeb0cf0f
2 changes: 1 addition & 1 deletion apps/files_versions/lib/Db/VersionEntity.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public function getMetadataValue(string $key): ?string {
* @param string $key key associated with the value
* @param string $value value associated with the key
*/
public function setMetadataValue(string $key, $value): void {
public function setMetadataValue(string $key, string $value): void {
$this->metadata[$key] = $value;
$this->markFieldUpdated('metadata');
}
Expand Down
4 changes: 2 additions & 2 deletions apps/files_versions/lib/Listener/MetadataFileEvents.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/**
* @author Eduardo Morales emoral435@gmail.com>
*
* @license AGPL-3.0
* @license GNU AGPL-3.0-or-later
*
* This code is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License, version 3,
Expand Down Expand Up @@ -62,7 +62,7 @@ public function post_write_hook(Node $node): void {
// check if our version manager supports setting the metadata
if ($this->versionManager instanceof IMetadataVersionBackend) {
$author = $user->getUID();
$this->versionManager->setMetadataValue($node, "author", $author);
$this->versionManager->setMetadataValue($node, 'author', $author);
}
}
}
4 changes: 2 additions & 2 deletions apps/files_versions/lib/Versions/IMetadataVersion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/**
* @copyright Copyright (c) 2024 Eduardo Morales <emoral435@gmail.com>
*
* @license GNU AGPL version 3 or any later version
* @license GNU AGPL-3.0-or-later
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
Expand All @@ -29,7 +29,7 @@
*/
interface IMetadataVersion {
/**
* @abstract retrieves the metadata value from our $key param
* retrieves the metadata value from our $key param
*
* @param string $key the key for the json value of the metadata column
* @since 29.0.0
Expand Down
2 changes: 1 addition & 1 deletion apps/files_versions/lib/Versions/IMetadataVersionBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/**
* @copyright Copyright (c) 2024 Eduardo Morales <emoral435@gmail.com>
*
* @license GNU AGPL version 3 or any later version
* @license GNU AGPL-3.0-or-later
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
Expand Down