Skip to content

Split live photo listener to extract trashbin specific code into its own listener #44069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 4 commits into from
Mar 14, 2024
Merged

Split live photo listener to extract trashbin specific code into its own listener #44069

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
caa720c
test(cypress): Do not run cron in ajax mode
artonge Mar 12, 2024
d9e09d5
test(cypress): Scroll element in the center of the view
artonge Mar 12, 2024
2de9880
fix(files): Do not require files_trashbin in live photo sync listener
artonge Mar 12, 2024
01fe326
test(files): Add e2e tests for live photo sync
artonge Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(cypress): Scroll element in the center of the view 
This avoid elements to be hided by a fixed top bar.
Especially useful for the file list.

Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge
artonge committed Mar 14, 2024
commit d9e09d5883e6cca4c61c874e1518dc92dd0a1bde
4 changes: 4 additions & 0 deletions cypress.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ export default defineConfig({
// faster video processing
videoCompression: false,

// Prevent elements to be scrolled under a top bar during actions (click, clear, type, etc). Default is 'top'.
// https://github.com/cypress-io/cypress/issues/871
scrollBehavior: 'center',

// Visual regression testing
env: {
failSilently: false,
Expand Down