Skip to content

Allow social sharing to specify if a new window is opened #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Apr 20, 2017
Merged

Allow social sharing to specify if a new window is opened #4409

MorrisJobke merged 1 commit into from
Apr 20, 2017

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Apr 20, 2017

For nextcloud/socialsharing#5

For example mail shares should not open a new window because it looks
weird.

Signed-off-by: Roeland Jago Douma [email protected]

@rullzer
Allow social sharing to specify if a new window is opened
48fd0ee 
For example mail shares should not open a new window because it looks
weird.

Signed-off-by: Roeland Jago Douma <[email protected]>
@rullzer rullzer added 3. to review Waiting for reviews enhancement labels Apr 20, 2017
@rullzer rullzer added this to the Nextcloud 12.0 milestone Apr 20, 2017
MorrisJobke
MorrisJobke approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

ChristophWurst
ChristophWurst approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 20, 2017
@codecov
Copy link

codecov bot commented Apr 20, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@140580f). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #4409   +/-   ##
=========================================
  Coverage          ?   54.15%           
  Complexity        ?    21630           
=========================================
  Files             ?     1328           
  Lines             ?    82781           
  Branches          ?     1312           
=========================================
  Hits              ?    44828           
  Misses            ?    37953           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
core/js/sharesocialmanager.js 87.5% <ø> (ø) 0 <0> (?)
core/js/sharedialoglinkshareview.js 51.59% <0%> (ø) 0 <0> (?)

@MorrisJobke MorrisJobke merged commit 9536cbf into master Apr 20, 2017
@MorrisJobke MorrisJobke deleted the socialharing_mail branch April 20, 2017 22:59
@snyk-bot snyk-bot mentioned this pull request Oct 17, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Nov 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@schiessle schiessle Awaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @MorrisJobke @ChristophWurst