Skip to content

Conversation

@helmo
Copy link
Contributor

@helmo helmo commented Mar 8, 2024

Summary

While working on #42449 I noticed that a log string was incorrect. And since that is now resolved via another PR I've spun this off into a separate branch.

console.php and cron.php logging the same name was a bit confusing at one time. So this is the fix.

Checklist

Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarity is important. 🙂 Thanks!

@Altahrim Altahrim mentioned this pull request Mar 12, 2024
@Altahrim
Copy link
Collaborator

Altahrim commented Mar 12, 2024

@helmo Could you rebase and reword your commit using conventional commits?

@helmo helmo force-pushed the name-fix branch 2 times, most recently from 3cea598 to eb224c8 Compare March 12, 2024 14:57
@helmo
Copy link
Contributor Author

helmo commented Mar 12, 2024

@Altahrim that should do it.

@Altahrim
Copy link
Collaborator

@helmo Can you also sign your commit to pass DCO please?
You can do it with git commit --amend -s

@Altahrim Altahrim mentioned this pull request Mar 14, 2024
@Altahrim Altahrim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2024
@skjnldsv skjnldsv merged commit 4cf392f into nextcloud:master Mar 14, 2024
@welcome
Copy link

welcome bot commented Mar 14, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: logging feature: occ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants