Skip to content

fix(theming): fix incorrectly inverted favicons #44119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Mar 11, 2024
Merged

fix(theming): fix incorrectly inverted favicons #44119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(theming): fix incorrectly inverted favicons 
Signed-off-by: Simon L <[email protected]>
  • Loading branch information
@szaimen
szaimen committed Mar 11, 2024
commit 03d19f14a64592999998dea20571cae065cd17cf
2 changes: 1 addition & 1 deletion apps/theming/lib/IconBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public function renderAppIcon($app, $size) {
* invert app icons for bright primary colors
* the default nextcloud logo will not be inverted to black
*/
if ($this->util->invertTextColor($color)
if ($this->util->isBrightColor($color)
&& !$appIcon instanceof ISimpleFile
&& $app !== "core"
) {
Expand Down