feat: Apps discover section #44129
Merged
feat: Apps discover section #44129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
susnux
force-pushed
the
feat/discover-apps-section
branch
from
abd6b12 to
d03ab07
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
susnux
force-pushed
the
feat/discover-apps-section
branch
from
d03ab07 to
0fbd4fe
Compare
susnux
force-pushed
the
feat/discover-apps-section
branch
2 times, most recently
from
ccca095 to
e5992a7
Compare
susnux
added
enhancement
3. to review
Merged
Altahrim
reviewed
Mar 14, 2024
Collaborator
Altahrim
left a comment
Altahrim
left a comment
There was a problem hiding this comment.
Few comments on PHP part
susnux
force-pushed
the
feat/discover-apps-section
branch
2 times, most recently
from
804a107 to
1c8ba07
Compare
skjnldsv
reviewed
Mar 14, 2024
susnux
force-pushed
the
feat/discover-apps-section
branch
from
1c8ba07 to
6b3e62e
Compare
skjnldsv
reviewed
Mar 14, 2024
Comment on lines
134
to
138
| // $data = $this->discoverFetcher->get(); | ||
|
|
||
| // TODO REMOVE JUST FOR TESTING | ||
| $file = file_get_contents(__DIR__ . '/../../discover.json'); | ||
| $data = json_decode($file); |
Pytal
approved these changes
Mar 14, 2024
Member
Pytal
left a comment
Pytal
left a comment
There was a problem hiding this comment.
Other than minor remarks ✅, did not test
susnux
force-pushed
the
feat/discover-apps-section
branch
from
6b3e62e to
1ac9d62
Compare
susnux
force-pushed
the
feat/discover-apps-section
branch
from
1ac9d62 to
5adc667
Compare
Pytal
reviewed
Mar 14, 2024
susnux
force-pushed
the
feat/discover-apps-section
branch
from
5adc667 to
f600ef6
Compare
emoral435
approved these changes
Mar 14, 2024
Contributor
emoral435
left a comment
emoral435
left a comment
There was a problem hiding this comment.
Tested on my local dev - looks really cool :) Small questions but overall - fantastic PR!
susnux
force-pushed
the
feat/discover-apps-section
branch
from
f600ef6 to
c4d1d97
Compare
susnux
force-pushed
the
feat/discover-apps-section
branch
from
c4d1d97 to
96f6907
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Benjamin Gaussorgues <[email protected]> Co-authored-by: Ferdinand Thiessen <[email protected]> Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Altahrim
force-pushed
the
feat/discover-apps-section
branch
from
96f6907 to
a61cef9
Compare
Collaborator
|
Removed the test commit |
Altahrim
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
vokoscreenNG-2024-03-12_16-40-31.mp4
TODO
(maybe follow up) Implement show case type(follow up)Checklist