Do not throw an exception if the etag is not set in metadata #44189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
3. to review
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/do_not_throw_exception_if_etag_is_not_set
branch
from
3fe77a6 to
8205de7
Compare
susnux
approved these changes
Mar 14, 2024
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Makes sense and is consistent with out other getETag functions
Merged
skjnldsv
approved these changes
Mar 16, 2024
skjnldsv
deleted the
artonge/fix/do_not_throw_exception_if_etag_is_not_set
branch
Merged
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if no
etagis set for the metadata, the caller need to wrapgetEtagin atry/catch, else, the provider will always fail at the same place. This returns an empty string instead of throwing.