Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 16, 2024

Summary

Based on this: #24330 (comment)

So this makes the concurrency option configurable which might help in some cases, but still defaults to 5 like the S3 SDK is doing.

Docs: nextcloud/documentation#11661

Checklist

@susnux
Copy link
Contributor Author

susnux commented Mar 17, 2024

No idea whats up with Cypress, but that is unrelated...

@Altahrim Altahrim mentioned this pull request Mar 18, 2024
@susnux susnux requested a review from come-nc March 19, 2024 15:29
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
@susnux susnux force-pushed the enh/s3-connectivity branch from 67e17de to 32dee2f Compare March 21, 2024 15:25
@susnux susnux requested a review from come-nc March 21, 2024 15:26
@susnux susnux merged commit a35edaa into master Mar 21, 2024
@susnux susnux deleted the enh/s3-connectivity branch March 21, 2024 18:01
@come-nc
Copy link
Contributor

come-nc commented Mar 25, 2024

@susnux https://github.com/nextcloud/server/actions/runs/8413780258/job/23036516249 Sorry I missed that, you cannot type sizes as int, it breaks on 32bits, you should use int|float.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants