Skip to content

fix: Correctly add search event listener to make searching the app list work again #44255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Mar 18, 2024
Merged

fix: Correctly add search event listener to make searching the app list work again #44255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d750cf
fix(settings): Add event search listener on mounted to guarantee func…
susnux Mar 17, 2024
65cb1fc
chore: Compile assets
susnux Mar 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(settings): Add event search listener on mounted to guarantee func… 
…tion exists

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
  • Loading branch information
@susnux
susnux committed Mar 18, 2024
commit 8d750cfd1510177e27dd67bebd39ea748331b60c
6 changes: 3 additions & 3 deletions apps/settings/src/components/AppList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,14 +266,14 @@ export default {
unsubscribe('nextcloud:unified-search.reset', this.resetSearch)
},

beforeCreate() {
mounted() {
subscribe('nextcloud:unified-search.search', this.setSearch)
subscribe('nextcloud:unified-search.reset', this.resetSearch)
},

methods: {
setSearch(value) {
this.search = value
setSearch({ query }) {
this.search = query
},
resetSearch() {
this.search = ''
Expand Down
Loading