Skip to content

Conversation

@RajeevDash007
Copy link
Contributor

@RajeevDash007
Copy link
Contributor Author

@skjnldsv Please review this

@susnux susnux requested review from a team, Pytal, emoral435 and szaimen and removed request for a team March 17, 2024 18:37
@RajeevDash007
Copy link
Contributor Author

its been approved by 2 reviewers,
I guess, Now its ready to be merged.
I hope, one of the maintainers will merge it

Signed-off-by: Rajeev Lochan Dash <[email protected]>
@susnux
Copy link
Contributor

susnux commented Mar 18, 2024

I think cypress always fails for forks, so we need the force-merge power of @skjnldsv

@RajeevDash007
Copy link
Contributor Author

RajeevDash007 commented Mar 19, 2024

yes @skjnldsv

@skjnldsv skjnldsv merged commit cfca735 into nextcloud:master Mar 19, 2024
@welcome
Copy link

welcome bot commented Mar 19, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 19, 2024
@Altahrim Altahrim mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new codespace link to docs

4 participants