Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 17, 2024

Summary

When the configuration is not a valid integer do not silently fallback to warn, instead try to cast it (might be more what the admin wanted to configure, e.g. allows '0' when 0 was meant).
And if the value is invalid do handle it not silently but at least put a warning in the log (even we do not have access to the logger we can put it in the error log.

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Mar 17, 2024
@susnux susnux requested review from a team, ArtificialOwl, nfebe, nickvergessen and sorbaugh and removed request for a team March 17, 2024 20:17
@Altahrim Altahrim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 18, 2024
@nickvergessen nickvergessen merged commit 3af954f into master Mar 18, 2024
@nickvergessen nickvergessen deleted the fix/log-on-invalid-loglevel branch March 18, 2024 09:59
@Altahrim Altahrim mentioned this pull request Mar 18, 2024
@skjnldsv
Copy link
Member

Thank you for the additional fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: logging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants