fix(setupcheck): Catch Throwables from setup checks and show them to the admin #44270
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the admin This avoids letting a buggy setup check from an application crash the setupcheck system. The throwable is shown instead. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
ArtificialOwl,
nfebe and
sorbaugh
and removed request for
a team
susnux
reviewed
Mar 18, 2024
Signed-off-by: Côme Chilliet <[email protected]>
nickvergessen
approved these changes
Mar 25, 2024
Altahrim
approved these changes
Mar 25, 2024
bigcat88
approved these changes
Mar 25, 2024
Merged
susnux
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This avoids letting a buggy setup check from an application crash the
setupcheck system. The throwable is shown instead.
Checklist