Skip to content

fix(config): Make sure user keys are strings #44276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Mar 20, 2024
Merged

fix(config): Make sure user keys are strings #44276

skjnldsv merged 1 commit into from
Mar 20, 2024

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 18, 2024 •
edited
Loading

  • Resolves: #

Summary

array_keys returns string[]|int[] and out API should only return string[].

TODO

  • ...

Checklist

@ChristophWurst ChristophWurst added bug 2. developing Work in progress labels Mar 18, 2024
@ChristophWurst ChristophWurst marked this pull request as ready for review March 19, 2024 17:28
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 19, 2024
@ChristophWurst ChristophWurst force-pushed the fix/config/string-user-keys branch from c370652 to b8868e2 Compare March 19, 2024 17:28
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 19, 2024

/backport! to stable28

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 19, 2024

/backport! to stable27

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 19, 2024

/backport! to stable26

@backportbot backportbot bot mentioned this pull request Mar 19, 2024
Merged
@ChristophWurst ChristophWurst added this to the Nextcloud 29 milestone Mar 19, 2024
This was referenced Mar 19, 2024
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 19, 2024
Merged
skjnldsv
skjnldsv approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test

@skjnldsv skjnldsv merged commit c34e252 into master Mar 20, 2024
@skjnldsv skjnldsv deleted the fix/config/string-user-keys branch March 20, 2024 07:19
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 20, 2024
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
Merged
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 26, 2024

/backport! to stable25

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 26, 2024

/backport to stable24

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 26, 2024

/backport to stable23

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 26, 2024

/backport to stable22

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 26, 2024

/backport to stable21

@backportbot backportbot bot mentioned this pull request Mar 26, 2024
Merged
This was referenced Mar 26, 2024
Merged
Merged
Merged
Merged
@DeepDiver1975 DeepDiver1975 mentioned this pull request Jun 18, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristophWurst @nickvergessen @skjnldsv