Skip to content

fix(settings): Ensure media for app discover section is scaled correctly #44286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 3 commits into from
Mar 19, 2024
Merged

fix(settings): Ensure media for app discover section is scaled correctly #44286

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0a9b59
fix(settings): Show proper warning if app discover section could not …
susnux Mar 18, 2024
e590626
fix(settings): Fit media into post type (app discover section)
susnux Mar 18, 2024
d71e693
chore: Compile assets
susnux Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(settings): Show proper warning if app discover section could not … 
…be fetched

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Mar 19, 2024
commit c0a9b59d2695cf47cb0d4f92e2a153aa8d7fbdc0
5 changes: 5 additions & 0 deletions apps/settings/src/components/AppStoreDiscover/AppStoreDiscoverSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ const shuffleArray = <T, >(array: T[]): T[] => {
onBeforeMount(async () => {
try {
const { data } = await axios.get<Record<string, unknown>[]>(generateUrl('/settings/api/apps/discover'))
if (data.length === 0) {
logger.info('No app discover elements available (empty response)')
hasError.value = true
return
}
// Parse data to ensure dates are useable and then filter out expired or future elements
const parsedElements = data.map(parseApiResponse).filter(filterElements)
// Shuffle elements to make it looks more interesting
Expand Down