Skip to content

fix(metdata): Correctly handle FilesMetadataNotFoundException on blurhash generation #44304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SystemKeeper wants to merge 1 commit into from
Closed

fix(metdata): Correctly handle FilesMetadataNotFoundException on blurhash generation #44304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(metdata): Correctly handle FilesMetadataNotFoundException on blur… 
…hash generation

Signed-off-by: Marcel Müller <[email protected]>
  • Loading branch information
@SystemKeeper
SystemKeeper committed Mar 19, 2024
commit a9399ac85cbf2c361e6d1350d0f30c15277a2d9e
9 changes: 7 additions & 2 deletions lib/private/Blurhash/Listener/GenerateBlurhashMetadata.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
use OCP\FilesMetadata\AMetadataEvent;
use OCP\FilesMetadata\Event\MetadataBackgroundEvent;
use OCP\FilesMetadata\Event\MetadataLiveEvent;
use OCP\FilesMetadata\Exceptions\FilesMetadataNotFoundException;
use OCP\IPreview;
use OCP\Lock\LockedException;

Expand Down Expand Up @@ -74,8 +75,12 @@ public function handle(Event $event): void {

$currentEtag = $file->getEtag();
$metadata = $event->getMetadata();
if ($metadata->getEtag('blurhash') === $currentEtag) {
return;

try {
if ($metadata->getEtag('blurhash') === $currentEtag) {
return;
}
} catch (FilesMetadataNotFoundException) {
}

// too heavy to run on the live thread, request a rerun as a background job
Expand Down