Skip to content

fix(sharing): resolveGroupShares setPermissions on null #44316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Mar 19, 2024
Merged

fix(sharing): resolveGroupShares setPermissions on null #44316

skjnldsv merged 1 commit into from
Mar 19, 2024

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 19, 2024

Fix #44314

This is just mitigating the error itself, I don't know if the logic make sense overall

@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Mar 19, 2024
@skjnldsv skjnldsv requested review from a team and icewind1991 March 19, 2024 12:10
@skjnldsv skjnldsv self-assigned this Mar 19, 2024
@skjnldsv skjnldsv requested review from ArtificialOwl and sorbaugh and removed request for a team March 19, 2024 12:10
@icewind1991
Copy link
Member

icewind1991 commented Mar 19, 2024

Makes sense.

I originally thought that wouldn't be needed as there should only be USERGROUP shares if there is a matching parent share. But I guess not...

@skjnldsv skjnldsv requested review from artonge and come-nc March 19, 2024 12:10
artonge
artonge approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The null 'parent' might occur for the root parent share itself?
Another solution would be to add a condition on 'parent' in the query so it is not null?

@Altahrim Altahrim mentioned this pull request Mar 19, 2024
Merged
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 19, 2024
@skjnldsv skjnldsv merged commit 323acaf into master Mar 19, 2024
@skjnldsv skjnldsv deleted the fix/resolveGroupShares branch March 19, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@artonge artonge artonge approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing regression

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

[Bug] Call to a member function setPermissions() on null

4 participants

@skjnldsv @icewind1991 @artonge