feat(settings): Implement showcase type for App Discover section
#44328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
3. to review
Merged
susnux
force-pushed
the
feat/app-discover-showcase-type
branch
from
62e0da1 to
939c3a2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…le width Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/app-discover-showcase-type
branch
from
939c3a2 to
f5bfdc8
Compare
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/app-discover-showcase-type
branch
from
f5bfdc8 to
d58f3e3
Compare
Contributor
Author
@Pytal no I needed to rebase, should work now :) |
Pytal
approved these changes
Mar 19, 2024
AndyScherzinger
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the last missing piece the
showcasetype - basically a list of posts or apps.TODO
In a follow up some design related changes might be needed as currently for apps the AppItem is reused, but that component should probably be split into two:
AppListTableRowandAppListGridItemas otherwise the grid one (used here) look a bit weird - especially if the app is featured and have a rating.Checklist