Skip to content

Conversation

@LukasReschke
Copy link
Member

Limits the amount of solvechallenge requests to 5 per user in 100 seconds. Note that you need to have Redis enabled to be able to test it :)

Fixes #2626

Signed-off-by: Lukas Reschke [email protected]

@LukasReschke LukasReschke added 3. to review Waiting for reviews security labels Apr 22, 2017
@LukasReschke LukasReschke added this to the Nextcloud 12.0 milestone Apr 22, 2017
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, it's a rate limit for any second factor provider 😉

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 24, 2017
@codecov
Copy link

codecov bot commented Apr 24, 2017

Codecov Report

Merging #4434 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #4434      +/-   ##
===========================================
- Coverage     54.03%   53.9%   -0.14%     
- Complexity    21640   21840     +200     
===========================================
  Files          1268    1327      +59     
  Lines         75522   83569    +8047     
  Branches          0    1312    +1312     
===========================================
+ Hits          40812   45045    +4233     
- Misses        34710   38524    +3814
Impacted Files Coverage Δ Complexity Δ
core/Controller/TwoFactorChallengeController.php 84.37% <ø> (ø) 13 <0> (ø) ⬇️
apps/dav/lib/CalDAV/CalDavBackend.php 57.98% <0%> (-27.64%) 237% <0%> (+56%)
apps/dav/lib/CardDAV/CardDavBackend.php 65.14% <0%> (-17.98%) 181% <0%> (+93%)
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
core/js/config.js 6.66% <0%> (ø) 0% <0%> (?)
apps/comments/js/filesplugin.js 80% <0%> (ø) 0% <0%> (?)
core/js/eventsource.js 7.69% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/sharedfilelist.js 93.63% <0%> (ø) 0% <0%> (?)
core/js/sharedialogview.js 75.96% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/sharetabview.js 83.33% <0%> (ø) 0% <0%> (?)
... and 57 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants