Skip to content

[stable28] Fix default text processing provider in AI settings #44343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julien-nc merged 1 commit into from
Apr 8, 2024
Merged

[stable28] Fix default text processing provider in AI settings #44343

julien-nc merged 1 commit into from
Apr 8, 2024

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Mar 19, 2024

Manual backport of #43993

@julien-nc julien-nc added this to the Nextcloud 28.0.5 milestone Mar 19, 2024
@julien-nc julien-nc requested review from a team, Altahrim, ArtificialOwl and nfebe and removed request for a team March 21, 2024 11:51
@julien-nc julien-nc force-pushed the backport/43993/stable28 branch from 83b0c17 to 51f5c4b Compare March 25, 2024 09:34
@julien-nc julien-nc force-pushed the backport/43993/stable28 branch from 51f5c4b to cc04d00 Compare April 3, 2024 10:11
@julien-nc julien-nc enabled auto-merge April 3, 2024 10:18
@julien-nc julien-nc disabled auto-merge April 3, 2024 10:54
@julien-nc
Copy link
Member Author

julien-nc commented Apr 3, 2024

Drone failure is not related.
In sqlite-php8.0:

There was 1 failure:

1) Test\User\DatabaseTest::testSearch
Failed asserting that actual size 3 matches expected size 2.

/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:124

@Altahrim Altahrim added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 3, 2024
@julien-nc
fix: when no AI setting has been set, make sure the selected text pro…
52de9ea 
…cessing provider is the same as the one that will be used

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc force-pushed the backport/43993/stable28 branch from cc04d00 to 52de9ea Compare April 8, 2024 08:38
@julien-nc julien-nc merged commit f89dabb into stable28 Apr 8, 2024
@julien-nc julien-nc deleted the backport/43993/stable28 branch April 8, 2024 10:07
@Altahrim Altahrim mentioned this pull request Apr 17, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@Altahrim Altahrim Altahrim approved these changes

@nfebe nfebe nfebe approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish bug feature: text processing

Projects

None yet

Milestone

Nextcloud 28.0.5

Development

Successfully merging this pull request may close these issues.

5 participants

@julien-nc @marcelklehr @Altahrim @nfebe