Skip to content

log error when default getWrapperStorage would return null #44357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 2 commits into from
Mar 22, 2024
Merged

log error when default getWrapperStorage would return null #44357

skjnldsv merged 2 commits into from
Mar 22, 2024

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Mar 20, 2024 •
edited
Loading

and return a FailedStorage instead of null.

This should hopefully make things more resistant against wrapper issues.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 20, 2024
@icewind1991 icewind1991 added this to the Nextcloud 29 milestone Mar 20, 2024
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, nfebe and sorbaugh and removed request for a team March 20, 2024 13:11
@icewind1991 icewind1991 changed the title fix: make StorageWrapper::instanceOfStorage more resilient against mi… log error when default getWrapperStorage would return null Mar 20, 2024
@icewind1991 icewind1991 force-pushed the wrapper-instanceof-resiliant branch from 20b2076 to d5fa2ec Compare March 20, 2024 13:26
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 20, 2024
View reviewed changes
@icewind1991 icewind1991 force-pushed the wrapper-instanceof-resiliant branch from 1c23bb1 to 85b5dd0 Compare March 20, 2024 13:49
@Altahrim Altahrim mentioned this pull request Mar 20, 2024
Merged
@icewind1991
Copy link
Member Author

icewind1991 commented Mar 22, 2024

/backport to stable28

@icewind1991
Copy link
Member Author

icewind1991 commented Mar 22, 2024

/backport to stable27

@skjnldsv skjnldsv merged commit fb97d55 into master Mar 22, 2024
@skjnldsv skjnldsv deleted the wrapper-instanceof-resiliant branch March 22, 2024 19:43
This was referenced Mar 22, 2024
Merged
Merged
@Altahrim Altahrim mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991 @susnux @skjnldsv