Skip to content

fix(caldav): add EXDATE and EXRULE to confidential object #44360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miaulalala merged 1 commit into from
Mar 21, 2024
Merged

fix(caldav): add EXDATE and EXRULE to confidential object #44360

miaulalala merged 1 commit into from
Mar 21, 2024

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Mar 20, 2024 •
edited
Loading

Summary

The EXDATE / EXRULE properties are lost when a confidential object is created.

Checklist

@miaulalala miaulalala added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Mar 20, 2024
@miaulalala miaulalala added this to the Nextcloud 29 milestone Mar 20, 2024
@miaulalala miaulalala requested a review from st3iny March 20, 2024 14:24
@miaulalala miaulalala self-assigned this Mar 20, 2024
@miaulalala
Copy link
Contributor Author

miaulalala commented Mar 20, 2024

/backport to stable28

@miaulalala
Copy link
Contributor Author

miaulalala commented Mar 20, 2024

/backport to stable27

@miaulalala
Copy link
Contributor Author

miaulalala commented Mar 20, 2024

/backport to stable26

@Altahrim Altahrim mentioned this pull request Mar 20, 2024
Merged
tcitworld
tcitworld approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense

tcitworld
tcitworld reviewed Mar 20, 2024
View reviewed changes
@miaulalala miaulalala force-pushed the fix/add-exdate-exrule-to-confidential-object branch from 2c2165c to 9999f15 Compare March 20, 2024 17:33
@miaulalala miaulalala force-pushed the fix/add-exdate-exrule-to-confidential-object branch from 9999f15 to a96f8f7 Compare March 21, 2024 09:01
@miaulalala miaulalala enabled auto-merge March 21, 2024 11:45
@miaulalala miaulalala merged commit bdd4ac2 into master Mar 21, 2024
@miaulalala miaulalala deleted the fix/add-exdate-exrule-to-confidential-object branch March 21, 2024 13:34
This was referenced Mar 21, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcitworld tcitworld tcitworld approved these changes

@kesselb kesselb kesselb approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

Assignees

@miaulalala miaulalala

Labels

3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

Removed Single Occurrence of Reoccurring, Confidential Event Remains on Shared Calendar

4 participants

@miaulalala @tcitworld @kesselb