Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 21, 2024

Summary

Grant write-properties permission to shared addressbooks (to disable, change the local name, etc)

Checklist

@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews feature: dav feature: carddav Related to CardDAV internals labels Mar 21, 2024
@ChristophWurst ChristophWurst added this to the Nextcloud 29 milestone Mar 21, 2024
@ChristophWurst ChristophWurst self-assigned this Mar 21, 2024
@ChristophWurst
Copy link
Member Author

/backport! to stable28

@ChristophWurst
Copy link
Member Author

/backport! to stable27

@nickvergessen
Copy link
Member

Failing tests are related:

  1. OCA\DAV\Tests\unit\CardDAV\AddressBookTest::testAcl with data set "read-only property not set" (true, null, true)

@ChristophWurst ChristophWurst force-pushed the fix/dav/acls-shared-addressbook branch from 476fd81 to b6e1685 Compare March 21, 2024 10:50
@ChristophWurst ChristophWurst mentioned this pull request Mar 21, 2024
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 21, 2024
@hamza221
Copy link
Contributor

Cypress failure doesn't look related, rerunning

@hamza221 hamza221 merged commit 007b54a into master Mar 21, 2024
@hamza221 hamza221 deleted the fix/dav/acls-shared-addressbook branch March 21, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: carddav Related to CardDAV internals feature: dav

Projects

Development

Successfully merging this pull request may close these issues.

5 participants