fix(DB): Sanitize host parameter for postgres databases when IPv6 address is passed
#44394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
a team,
Altahrim,
nfebe and
sorbaugh
and removed request for
a team
Contributor
Author
|
BTW this was introduced with Nextcloud 28 and the update to Doctrine 3.7 |
Contributor
Author
|
/backport to stable28 |
Merged
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
For the future I fixed it upstream: doctrine/dbal#6344 |
susnux
force-pushed
the
fix/ipv6-postgres
branch
from
e74b0f5 to
4c49d12
Compare
Altahrim
approved these changes
Mar 25, 2024
nickvergessen
approved these changes
Mar 25, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Adding a test is too complicated/artificial I guess?
Merged
Contributor
Author
|
@nickvergessen I am not sure how to test this, for unit tests I would need to mock a static function. For integration tests we would need a specific database configuration. |
Member
|
yeah, that's exactly what I mean. |
…ddress is passed Doctrine is using `pg_connect` with the `host` parameter, this does not allow IPv6 addresses in URI notation. So we need to extract the IP address and pass it directly Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/ipv6-postgres
branch
from
4c49d12 to
2525e73
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Doctrine is using
pg_connectwith thehostparameter, this does not allow IPv6 addresses in URI notation. So we need to extract the IP address and pass it directlyChecklist