Skip to content

fix(dns): detect disabled IPv6 support in DNS pinning #44475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Altahrim merged 1 commit into from
Mar 26, 2024
Merged

fix(dns): detect disabled IPv6 support in DNS pinning #44475

Altahrim merged 1 commit into from
Mar 26, 2024

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Mar 26, 2024 •
edited
Loading

Summary

If IPv6 isn't supported (PHP compiled with --disable-ipv6 flag), don't try to resolve AAAA records

Checklist

@Altahrim Altahrim added bug 2. developing Work in progress php Pull requests that update Php code labels Mar 26, 2024
@Altahrim Altahrim self-assigned this Mar 26, 2024
@Altahrim Altahrim added 2. developing Work in progress 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 26, 2024
@Altahrim Altahrim requested review from a team, ArtificialOwl, kesselb, nfebe and sorbaugh and removed request for a team March 26, 2024 10:46
@Altahrim Altahrim added this to the Nextcloud 29 milestone Mar 26, 2024
@kesselb
Copy link
Contributor

kesselb commented Mar 26, 2024

Thank you 👍

Looks good to me. We may want to use the error suppress operator, like https://github.com/symfony/symfony/blob/78c6ceb5cd0560346b6765849f142c1c451fd1a8/src/Symfony/Component/HttpFoundation/IpUtils.php#L127

@Altahrim Altahrim marked this pull request as ready for review March 26, 2024 10:51
@Altahrim Altahrim removed the 2. developing Work in progress label Mar 26, 2024
@Altahrim
Copy link
Collaborator Author

Altahrim commented Mar 26, 2024

Actually, we could reuse the whole line…
socket is probably loaded in most installation and I think this test should be faster

@Altahrim Altahrim force-pushed the fix/disabled-ipv6 branch from 559ff57 to 7e4be1f Compare March 26, 2024 11:05
@Altahrim Altahrim requested a review from kesselb March 26, 2024 11:05
@Altahrim Altahrim mentioned this pull request Mar 26, 2024
Merged
@Altahrim Altahrim requested a review from come-nc March 26, 2024 16:03
@Altahrim Altahrim enabled auto-merge March 26, 2024 16:03
come-nc
come-nc approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@Altahrim Altahrim merged commit f8d1487 into master Mar 26, 2024
@Altahrim Altahrim deleted the fix/disabled-ipv6 branch March 26, 2024 17:14
@Altahrim Altahrim removed the 3. to review Waiting for reviews label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@Altahrim Altahrim

Labels

bug php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

[Bug]: RuntimeException: Unable to check Ipv6. Check that PHP was not compiled with option "disable-ipv6".

4 participants

@Altahrim @kesselb @come-nc